The branch, master has been updated via bead4fdb88c wafsamba: Enable warnings about zero-length formats via e6f84048279 wafsamba: Enable warnings about format overflows via d16e9dfc81d ctdb: Fix format in db_hash_test from 5a9e338330f ctdb-tests: Don't clean up test var directory in autotest target
https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit bead4fdb88c9684a6c0ed066194cecb5d186026d Author: Andreas Schneider <a...@samba.org> Date: Thu Feb 14 12:08:37 2019 +0100 wafsamba: Enable warnings about zero-length formats Signed-off-by: Andreas Schneider <a...@samba.org> Reviewed-by: Ralph Boehme <s...@samba.org> Autobuild-User(master): Andreas Schneider <a...@cryptomilk.org> Autobuild-Date(master): Tue May 7 18:45:06 UTC 2019 on sn-devel-184 commit e6f8404827958705a5d7fc92a43efed365dd0451 Author: Andreas Schneider <a...@samba.org> Date: Thu Feb 14 12:06:57 2019 +0100 wafsamba: Enable warnings about format overflows Signed-off-by: Andreas Schneider <a...@samba.org> Reviewed-by: Ralph Boehme <s...@samba.org> commit d16e9dfc81d7d79c8d2bcffc66b6fe008e726974 Author: Andreas Schneider <a...@samba.org> Date: Mon Apr 29 13:26:04 2019 +0200 ctdb: Fix format in db_hash_test error: ‘%04d’ directive writing between 4 and 11 bytes into a region of size 5 [-Werror=format-overflow=] sprintf(key, "key%04d", i); Signed-off-by: Andreas Schneider <a...@samba.org> Reviewed-by: Ralph Boehme <s...@samba.org> ----------------------------------------------------------------------- Summary of changes: buildtools/wafsamba/samba_autoconf.py | 2 ++ ctdb/tests/src/db_hash_test.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) Changeset truncated at 500 lines: diff --git a/buildtools/wafsamba/samba_autoconf.py b/buildtools/wafsamba/samba_autoconf.py index 06ec7da333a..0dbfd54393f 100644 --- a/buildtools/wafsamba/samba_autoconf.py +++ b/buildtools/wafsamba/samba_autoconf.py @@ -738,6 +738,8 @@ def SAMBA_CONFIG_H(conf, path=None): cflags='-Wmissing-field-initializers -Werror=missing-field-initializers', msg="Checking C99 init of nested structs."): conf.ADD_CFLAGS('-Wmissing-field-initializers', testflags=True) + conf.ADD_CFLAGS('-Wformat-overflow=2', testflags=True) + conf.ADD_CFLAGS('-Wformat-zero-length', testflags=True) conf.ADD_CFLAGS('-Wcast-align -Wcast-qual', testflags=True) conf.ADD_CFLAGS('-fno-common', testflags=True) diff --git a/ctdb/tests/src/db_hash_test.c b/ctdb/tests/src/db_hash_test.c index 1f93743e000..31aa5011653 100644 --- a/ctdb/tests/src/db_hash_test.c +++ b/ctdb/tests/src/db_hash_test.c @@ -99,7 +99,7 @@ static void do_traverse_test(enum db_hash_type type) { struct db_hash_context *dh = NULL; TALLOC_CTX *mem_ctx = talloc_new(NULL); - char key[] = "keyXXXX"; + char key[16] = "keyXXXX"; char value[] = "This is some test value"; int count, ret, i; -- Samba Shared Repository