The branch, master has been updated
via ae9fb93393b s4 lib socket: Ensure address string owned by parent
struct
from b93ae77a6f4 g_lock: Fix a typo
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit ae9fb93393bcadbc71328335e481e4381ecb65bf
Author: Gary Lockyer <[email protected]>
Date: Tue May 7 16:30:22 2019 +1200
s4 lib socket: Ensure address string owned by parent struct
The local address string was not owned by it's parent structure, which
caused a use after free error in
continue_ip_open_socket source4/librpc/rpc/dcerpc_sock.c:267
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13929
Signed-off-by: Gary Lockyer <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
Autobuild-User(master): Andrew Bartlett <[email protected]>
Autobuild-Date(master): Wed May 8 20:03:42 UTC 2019 on sn-devel-184
-----------------------------------------------------------------------
Summary of changes:
source4/lib/socket/socket_ip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/source4/lib/socket/socket_ip.c b/source4/lib/socket/socket_ip.c
index fd109a3eacd..2aba491e06c 100644
--- a/source4/lib/socket/socket_ip.c
+++ b/source4/lib/socket/socket_ip.c
@@ -999,7 +999,7 @@ static struct socket_address *ipv6_tcp_get_my_addr(struct
socket_context *sock,
return NULL;
}
- local->addr = talloc_strdup(mem_ctx, addrstring);
+ local->addr = talloc_strdup(local, addrstring);
if (!local->addr) {
talloc_free(local);
return NULL;
--
Samba Shared Repository
