On Tue, Oct 01, 2002 at 09:48:34AM +0200, Stefan (metze) Metzmacher wrote about '[PATCH] sam backend parameter': > Hi Jelmer, > > here's a patch witch changes the syntax of the sam backend parameter: > > now it's plugin[|DOMAIN][:options] ... I think it nicer:-) > > If you didn't accept that patch please move the 'strchr' to 'strrchr', (but > there're also a few other bugs, in the parsing sam_backend_string in > make_backend_entry()), because as it is now it didn't work with: > > plugin[:options][|DOMAIN] :-( > > plugin:/usr/lib/samba/sam_passdb.so:test|test2:test3|test4|MX.BASE > > breaks it... This would be fixed by changing strchr to strrchr... Your patch would break backwards compatibility, and that's where this format was aimed at initially.. Secondly, having the backend and the backend parameters seperated is not very logicial, especially for plugin.
Jelmer
