-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
> Yep, I think I changed the order of that test - because we use use the > 'snum' attached to the vuid if possible, so as to avoid expensive > lookups. The correct fix would be to fix lp_add_home() not to overwrite > things when it finds that the home dir share already exists. (Because > all the damage is actually done there - the order that the search is > done doesn't matter any more, as the share is added as session setup > time). > > Unfortunately the fix I was about to commit seems to be the opposite of > an earlier 'fix' for a related bug. I'll need to stare at this a bit > more... Andrew, Changing the order of the lookup without letting everyone know is a really bad thing. This is an incompatible change with 2.2. Since you described the correct fix, please take care of this. cheers, jerry ---------------------------------------------------------------------- Hewlett-Packard ------------------------- http://www.hp.com SAMBA Team ---------------------- http://www.samba.org GnuPG Key ---- http://www.plainjoe.org/gpg_public.asc ISBN 0-672-32269-2 "SAMS Teach Yourself Samba in 24 Hours" 2ed "You can never go home again, Oatman, but I guess you can shop there." --John Cusack - "Grosse Point Blank" (1997) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.0 (GNU/Linux) Comment: For info see http://quantumlab.net/pine_privacy_guard/ iD8DBQE+FHWfIR7qMdg1EfYRAroZAKCmA1zv37Cbz5CkXVzBvEG/yAxrCgCgqoeF 0xfeqyczgN14iM8MEmT8GGs= =U5Gm -----END PGP SIGNATURE-----