On Fri, 2003-01-03 at 04:23, Gerald (Jerry) Carter wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > > > Yep, I think I changed the order of that test - because we use use the > > 'snum' attached to the vuid if possible, so as to avoid expensive > > lookups. The correct fix would be to fix lp_add_home() not to overwrite > > things when it finds that the home dir share already exists. (Because > > all the damage is actually done there - the order that the search is > > done doesn't matter any more, as the share is added as session setup > > time). > > > > Unfortunately the fix I was about to commit seems to be the opposite of > > an earlier 'fix' for a related bug. I'll need to stare at this a bit > > more... > > Andrew, Changing the order of the lookup without letting everyone > know is a really bad thing. This is an incompatible change with 2.2. > Since you described the correct fix, please take care of this.
Yep - will do. While yes, that is the 'correct' fix, the implementation in code isn't as straight-forward, particularly if we want changes to a user's 'homedir' to be updated. I'll certainly keep an eye on this one. Andrew Bartlett -- Andrew Bartlett [EMAIL PROTECTED] Manager, Authentication Subsystems, Samba Team [EMAIL PROTECTED] Student Network Administrator, Hawker College [EMAIL PROTECTED] http://samba.org http://build.samba.org http://hawkerc.net
signature.asc
Description: This is a digitally signed message part
