Update of task #10746 (project administration):
Status: None => In Progress
Assigned to: None => alexfernandez
_______________________________________________________
Follow-up Comment #1:
Hi Yasha,
I am reviewing your submission on behalf of Savannah. There are a few issues
with the project as submitted:
* Some of the files have a non-standard copyright header:
src/gtkcompletionline.cc, config/gmcommandrc... Please use the standard one as
explained in the GPL howto <http://www.gnu.org/licenses/gpl-howto.html>.
* Other files do not have a copyright header at all, like INSTALL or README.
For text files it is recommended to add the header at the bottom of the file
(so it's more accurately a copyright footer), but it should be there.
* The class src/ci_string.h states in the header: "This is a very nice class,
probably because it's not coded by me" but it does not contain a valid
copyright header.
* Finally, a suggestion: the tar file contains all the files in the top
level, while it would be nice to have a top directory called, e.g.
gmcommand-0.9.2/.
Could you provide an updated tarball so we can continue with the review?
Thanks!
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/task/?10746>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
