[
http://dev.sourcefabric.org/browse/LS-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15501#action_15501
]
Romain Beauxis commented on LS-495:
-----------------------------------
Hey!
I have just commited the assert(ns = []) as you suggested: I totally agree with
it.
As for the name vs. id vs. kind I think the whole thing should be rethough. I
discovered the kind part only when I started working on this and I don't think
it is used anywhere in telnet..
I also did not know the existence of name vs. id :)
However, I believe that we should not put too much on the same plate. This
issue is dedicated to a specific issue, that of making sure that telnet
commands are unregister when the source is destroyed. As it is now, I believe
the fix is "good enough" to merge it in the default branch (I'll do it your way
that time!).
Thus, I would recommend to:
+ Merge the branch now or with some more polishing if it needs to be
+ Open a new ticket about the confusion in names vs. kind vs. id
+ Deal with the new ticket after a stable release.
Sounds good?
> Deregister telnet commands on source's sleep
> --------------------------------------------
>
> Key: LS-495
> URL: http://dev.sourcefabric.org/browse/LS-495
> Project: Liquidsoap
> Issue Type: Bug
> Affects Versions: 1.0
> Reporter: Romain Beauxis
> Priority: Important
>
> Server/telnet command needs to be unregistered each time a source is shutdown
> in order to allow it to be garbage collected (and also to not polute..)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://dev.sourcefabric.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software
be a part of the solution? Download the Intel(R) Manageability Checker
today! http://p.sf.net/sfu/intel-dev2devmar
_______________________________________________
Savonet-devl mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-devl
