[
http://dev.sourcefabric.org/browse/LS-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416#action_17416
]
Romain Beauxis commented on LS-527:
-----------------------------------
Thanks for taking the time to respond!
Reading from the beginning, I think that there are two issues mentioned here:
* Too long timeout on output.icecast
* A freeze when raising an issue in output.icecast while using input.alsa
under it
Concerning the first one, I believe that the recent come-back of timeout in
output.icecast should allow to fix the first issue. It could be possible,
though, that this is a timeout during Unix.connect, which is not covered
(yet?). In any case, any issue on that would be better in a frest report I
think.
As for the second one, I believe that my patch is at least reasonable. As I
said, the only difference is that with the patch, we no longer call #leave on
the first source that fails but also on all sources that were initialized
before. I think it should have been done before anyway and should not hurt the
cases where it does not happen, thus the majority of the cases.
The code is indeed full of rollbacks but, unfortunately, I am not sure that
there is an elegant way to factorize it because one type of rollback happens
without an exception and the other one with one...
So I think I'm gonna go ahead and merge the changes. After that, I'll just
resolve the ticket and we'll use the close functionality for a good reason if
nothing bad happens.. :-)
> Exception raised + input.alsa -> freeze
> ---------------------------------------
>
> Key: LS-527
> URL: http://dev.sourcefabric.org/browse/LS-527
> Project: Liquidsoap
> Issue Type: Bug
> Components: Liquidsoap
> Reporter: Samuel Mimram
> Assignee: Romain Beauxis
> Priority: Blocker
> Attachments: LS-527.liq
>
>
> From the ML:
> While I was tweaking the "dynamic sources" script, I have discovered
> that (I guess) using an non-available port to connect to the streaming
> server is freezing the liquidsoap process. I don't know if it's expected
> or not.
> What I get from the log is:
> 2011/05/12 18:03:52 [output(dot)shoutcast:2] Connection failed: could
> not connect to host: Connection timed out in connect()!
> 2011/05/12 18:03:52 [clock.wallclock_main:2] Error when starting output
> output(dot)shoutcast: Tutils.Exit!
> In the meantime and after this, the telnet prompt is unavailable.
> Ctrl^C gives:
> 2011/05/12 18:07:30 [main:3] Shutdown started!
> 2011/05/12 18:07:30 [main:3] Waiting for threads to terminate...
> but with no success: the only way I have found to terminate liquidsoap
> is killall -9 liquidsoap.
> I have to specify that I am running liquidsoap in a virtual host.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://dev.sourcefabric.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
The must-attend event for mobile developers. Connect with experts.
Get tools for creating Super Apps. See the latest technologies.
Sessions, hands-on labs, demos & much more. Register early & save!
http://p.sf.net/sfu/rim-blackberry-1
_______________________________________________
Savonet-devl mailing list
Savonet-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-devl
