Incorrect typing of channels for input.http
-------------------------------------------
Key: LS-631
URL: http://dev.sourcefabric.org/browse/LS-631
Project: Liquidsoap
Issue Type: Bug
Reporter: Samuel Mimram
Priority: Major
The following was reported on the mailing list!
liquidsoap 'output.alsa(mksafe(input.http("http://mp36.bbc.streamuk.com:80/";)))'
Here is the Liquidsoap output:
2012/09/07 17:19:08 [alsa_out(default):3] Using ALSA 1.0.23.
2012/09/07 17:19:08 [alsa_out(default):2] Falling back on interleaved S16LE
2012/09/07 17:19:08 [alsa_out(default):3] Samplefreq=44100Hz, Bufsize=1048576B,
Frame=4B, Periods=1024
2012/09/07 17:19:08 [decoder:3] Method "MAD" accepted "audio/mpeg".
2012/09/07 17:19:08 [http_4984:3] Decoding...
2012/09/07 17:19:08 [mksafe:3] Switch to http_4984 with transition.
2012/09/07 17:19:08 [http_4984:3] Incorrect stream type!
2012/09/07 17:19:08 [mksafe:3] Switch to safe_blank with forgetful transition.
2012/09/07 17:19:08 [http_4984:2] Feeding stopped: Incorrect stream type!
2012/09/07 17:19:11 [decoder:3] Method "MAD" accepted "audio/mpeg".
2012/09/07 17:19:11 [http_4984:3] Decoding...
2012/09/07 17:19:11 [mksafe:3] Switch to http_4984 with transition.
2012/09/07 17:19:11 [http_4984:3] Incorrect stream type!
2012/09/07 17:19:11 [mksafe:3] Switch to safe_blank with forgetful transition.
2012/09/07 17:19:11 [http_4984:2] Feeding stopped: Incorrect stream type!
The "incorrect stream type" error comes from generator.ml and is due to the
fact that we get only one audio channel (the BBC stream is mono) whereas we
expect two (stereo). This should either
- have been detected at typing type
- have produced a better error message
- (my prefered for now) have produced a stereo stream
The snippet above can of course be corrected by inserting an audio_to_stereo
but the user has no idea about it from the error message...
More generally, while the typing of audio channels is theoretically nice, it
seems to have produced a lot of errors for not much for now. My point of view
is that at least conversion mono -> n channels should be implicit...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://dev.sourcefabric.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Savonet-devl mailing list
Savonet-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-devl
