On 04/14/2010 07:21 PM, Romain Beauxis wrote: > Le mercredi 14 avril 2010 18:24:05, David Baelde a écrit : > >> On Wed, Apr 14, 2010 at 10:50 AM, PyroPeter<[email protected]> wrote: >> >>> But I really don't get why someone would require a certain user for >>> make-install? >>> >> The most important use of the liquidsoap user is to run liquidsoap >> services not as root. As a result, we also need to install >> /var/log/liquidsoap such that it belongs to the liquidsoap user. We >> also install /etc/liquidsoap owned by the liquidsoap group, which is >> nice for typical uses: on a server, only radio admins edit this >> directory. >> > I fact there is the possibility to skip this part in the Makefile: > install-local: doc-install > ifneq ($(DEBIAN),yes) > $(INSTALL_DIRECTORY) -o ${user} -g ${group} -m 2775 \ > ${localstatedir}/log/liquidsoap > $(INSTALL_DIRECTORY) -o ${user} -g ${group} -m 2775 \ > ${localstatedir}/run/liquidsoap > endif > > In the Debian package, we invoke make install as: > make install DESTDIR=$(CURDIR)/debian/tmp/ DEBIAN=yes \ > prefix=$(CURDIR)/debian/tmp/usr \ > sysconfdir=$(CURDIR)/debian/tmp/etc > > But then the package has to create these directories itself. > > Similarly, the account creation is done in the install script of the package. > > if ! getent group liquidsoap>/dev/null 2>&1; then > addgroup --system liquidsoap > fi > > # Check for an account named 'liquidsoap' > if ! id liquidsoap>/dev/null 2>&1; then > # Create the new system account > adduser --system --disabled-password --disabled-login \ > --home /usr/share/liquidsoap --ingroup liquidsoap liquidsoap > fi > > # Add again /usr/share/liquidsoap if user was already created > if ! test -d /usr/share/liquidsoap; then > mkdir /usr/share/liquidsoap > fi > > # Fix directories ownership > chown -R root:root /usr/share/liquidsoap > chown -R liquidsoap:liquidsoap /var/log/liquidsoap > > I believe the AUR/Arch package should be able to do the same. > > It is unfortunate that the Makefile variable is called DEBIAN. Perhaps we > should rename > it to something like TO_PKG or something similar ? > > > Romain > I think the unixoid way would be to make DEBIAN=yes the default setting, as there is a very clear picture of what make-install should do, and it definitely does not include messing with anything outside $PREFIX and /etc.
------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Savonet-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/savonet-users
