2012/2/22 David Baelde <[email protected]>: > A fix is simple: replace `Autodetect by `Mpeg in > src/decoder/taglib_plug.ml. It tells taglib that the file is mpeg, > whatever its extension. It's a good idea in practice because taglib is > (afaik) only used for MP3, like the default mime and extensions > suggest. In theory it might be abusive: currently, nothing prevents us > from adding ogg mime type to call taglib, but forcing `Mpeg makes this > impossible. > > Am I missing something? should we adopt this pragmatic solution?
Well, first taglib may be used to decode metadata from other file types, such as one defined through external decoders, but that is really secondary. My own reasoning concerning file decoding is that providing a reliable file/media feeding system for your radio is very important. Also, if you take any mp3 file and change its extension then libmime may detect it as binary/octet or something like that. Once you allow garbage mime types to be considered as mp3, you open the door again to the possibility of false positive and decoding jpeg images etc.. Thus, I believe that it is advisable to put more friction on the user side to understand how file detection works so that they reflect it back on their media feeding system: we cannot make the impossible possible: feeding mp3 files with extensions that are not mp3 is likely to confuse the system. This is essentially for the same reason that we use static type inference.. It adds friction on the user side but helps them to design their script properly.. Romain ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Savonet-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/savonet-users
