I'm glad I could help. LS is awesome. Just let me know if I can help
with this issue further. I'll look forward to a fix! 

On Thu, 23 Feb 2012 00:23:10 +0100
David Baelde <[email protected]> wrote:

> Hi guys,
> 
> Damien, thanks for the extra tests. This clarifies the issue. It also
> prompted me to run the tests myself and I confirm the issue. In my
> opinion, this is a bug.
> 
> Romain, I disagree with your first proposition. It is quite annoying
> to have to fix the download extension. Our new decoding infrastructure
> based on mime types is precisely designed to avoid this. I prefer your
> second suggestion:
> 
> > Otherwise, the usual path is:
> >  * Download a file and make sure it has a .php extension.
> >  * Check with file -i /path/to/file.php what is the returned
> > mime-type
> >  * Add this mime-type to the following configuration key:
> >      set("decoder.mime_types.taglib",["audio/mpeg", "some/value"])
> >
> > This should tell liquidsoap to try to decode metadata for those
> > files using taglib. However, taglib also has its own automatic
> > format detection/guess, which may very well fail as well, still
> > because the mp3 format is loosy and you do not have a .mp3
> > extension.
> 
> The problem that we have here is that the downloaded file does have
> mime type audio/mpeg, so it should be accepted by our taglib decoder
> just like it is accepted by our mad decoder. My guess (like Romain
> said) is that we accept the file based on its mime type, but then
> taglib itself rejects it based on the extension (maybe due to the
> `Autodetect flag).
> 
> We should try to fix this, ie. ask taglib to trust our mime
> detection...


------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Savonet-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-users

Reply via email to