Hi,

Two news :)

The good one is that if compilation went that far, taglib compiled
successfully (I have thus updated to configure to >= 1.6)

The bad one is that it seems that it seems that we have used some
features which are not available with the version of ocaml in your
"old machine" (presumably it is < 3.12). The problem is very simple:
records defining a field whose value are stored in the same variable
such as

{
  field = field;
}

can be abbreviated to

{
  field;
}

starting from OCaml 3.12. The patch is quite simple too, just do the
converse to get backward compatibility :)

I have commited a patch to correct your error, you can see the diff
here : 
https://github.com/savonet/liquidsoap/commit/c62747b04d9eb2823fa463b1fd0e34c708d1777f

Presumably there will be more of those, so it would be nice if you
could patch them and submit a pull request (unfortunately I don't have
access to a machine with an old OCaml...). Of course, if you encounter
a problem which seems unreleated, don't hesitate to ask!

Cheers,

Samuel.

On Wed, Jan 30, 2013 at 6:00 PM, Martin Konečný
<[email protected]> wrote:
> Ok I attempted the compilation with taglib 1.6 I get the following
> compilation error:
>
>> make[3]: Entering directory `/home/martin/liquidsoap-full/liquidsoap/src'
>> OCAMLYACC lang/lang_parser.mly
>> OCAMLLEX lang/lang_lexer.mll
>> 238 states, 10610 transitions, table size 43868 bytes
>> 2966 additional bytes used for bindings
>> if test -d .svn && which svn > /dev/null ; then \
>>  url=`LC_ALL=C svn info | grep URL | \
>>       sed -e 's:.*svnroot/savonet/\(.*\)/src:\1:'`; \
>>  revision=`LC_ALL=C svn info | grep Revision | \
>>            sed -e 's/Revision: \(.*\)/\1/'`  ; \
>>  echo "let rev = \" ($url@rev$revision)\"" > SVN.ml ; \
>> elif test -d ../../.hg && which hg > /dev/null ; then \
>>  branch=`hg branch`; \
>>  revision=`LC_ALL=C hg parents | grep changeset: | \
>>       sed -e 's/changeset: *['0'-'9']*:\([^ ]*\).*/\1/'`; \
>>           date=`date +%Y%m%d:%H%M%S`; \
>>  echo "let rev = \" ($branch@$revision:$date)\"" > SVN.ml ; \
>> elif test -e ../.git && which git > /dev/null ; then \
>>  url=`git remote -v | grep fetch | sed 's/origin[ \t]*//' | sed 's/[
>> \t]*(.*)//'` ; \
>>  head=`git rev-parse HEAD` ; \
>>           date=`date +%Y%m%d:%H%M%S`; \
>>  echo "let rev = \" ($url@$head:$date)\"" > SVN.ml ; \
>> else \
>>  echo "let rev = \"\"" > SVN.ml ; \
>> fi
>> CAMLP4O outputs/harbor_output.camlp4
>> CAMLP4O tools/server.camlp4
>> CAMLP4O tools/harbor.camlp4
>> OCAMLDEP
>> File "tools/file_watcher_mtime.ml", line 47, characters 11-12:
>> Error: Syntax error
>> OCAMLOPT -c tools/stdlib.ml
>> OCAMLOPT -c tools/doc.ml
>> OCAMLOPT -c tools/plug.ml
>> OCAMLOPT -c tools/utils.ml
>> OCAMLOPT -c tools/dyntools.ml
>> OCAMLOPT -c tools/rqueue.ml
>> File "tools/rqueue.ml", line 1, characters 0-1:
>> Error: Could not find the .cmi file for interface tools/rqueue.mli.
>> make[3]: *** [tools/rqueue.cmx] Error 2
>> make[3]: Leaving directory `/home/martin/liquidsoap-full/liquidsoap/src'
>> make[2]: *** [all-auto-ocaml-prog] Error 2
>> make[2]: Leaving directory `/home/martin/liquidsoap-full/liquidsoap/src'
>> make[1]: *** [all-subdirs] Error 2
>> make[1]: Leaving directory `/home/martin/liquidsoap-full/liquidsoap'
>> make: *** [all] Error 1
>
>
>
> I cross checked against a system with taglib 1.7, and this error does not
> occur.
>
>
> On Mon, Jan 28, 2013 at 12:43 PM, Romain Beauxis <[email protected]>
> wrote:
>>
>> 2013/1/28 Martin Konečný <[email protected]>:
>> >
>> > On Mon, Jan 28, 2013 at 2:29 AM, Samuel Mimram <[email protected]>
>> > wrote:
>> >>
>> >> Could you please test this so that I can lower the requirements for
>> >> taglib?
>> >
>> >
>> >
>> > I can do this NP. What needs to be done? Simply edit
>> >
>> > PKG_CONFIG_CHECK_MODULE([taglib],[1.7])
>> >
>> > and then attempt to compile and run liquidsoap?
>>
>> Yup. Don't forget to ./bootstrap as well. Thanks!
>>
>> Romain
>
>
>
>
> --
> Open source radio in the cloud. Get yours now! ---> http://airtime.pro
>
> Martin Konecny
> Software Developer, Sourcefabric
> [email protected]
>
> 720 Bathurst St. Suite 203
> M5S 2R4, Toronto, ON, Canada
> +1 (416) 892-8420 (Cell)
> Skype: martin.konecny15
>
> http://www.sourcefabric.org
> http://www.twitter.com/Sourcefabric

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan
_______________________________________________
Savonet-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-users

Reply via email to