Hi John, I just pushed the fix to pass liquidsoap's metadata down to ffmpeg filters! They are passed only when the `pass_metadata` parameter is set to `true`. By default, it only passes them to audio streams. I'm making the assumption that metadata mostly matters for audio streams where they may hold track title/artist/album etc.
Hope this works for you! Romain Le lun. 23 août 2021 à 06:21, John Warburton <j...@johnwarburton.net> a écrit : > On Mon, 23 Aug 2021 at 08:36, Romain Beauxis <romain.beau...@gmail.com> > wrote: > >> Hi John, >> >> Thanks for this report. I actually pushed the changes to decode and pass >> metadata from ffmpeg frames when converting back to liquidsoap frame format >> in this PR: https://github.com/savonet/liquidsoap/pull/1812 >> >> In it, I failed to notice your use case and assumed that we could drop >> metadata when converting from liquidsoap frame format to ffmpeg's. I'll be >> fixing this shortly. >> >> When there's a blank piece of metadata (either title or artist), the > metadata doesn't update, even though I've put this code in: > > t = m["title"] > a = m["artist"] > if null.defined(t) then > t = "Unknown title" > end > if null.defined(a) then > a = "Unknown artist" > end > icy.update_metadata(host="127.0.0.1", port=8000, password="[PASSWORD]", > mount="audio.aac", [("title", t), ("artist", a)]) > > But t never seems to get updated to 'Unknown title', and a never gets > updated to 'Unknown artist'. > > Not sure how to check for undefined data, therefore. > > Maybe that difficulty could vanish with the new code that you are working > on. > with best wishes, > John > > _______________________________________________ > Savonet-users mailing list > Savonet-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/savonet-users >
_______________________________________________ Savonet-users mailing list Savonet-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/savonet-users
