On Tue, 24 Aug 2021 at 08:11, Romain Beauxis <romain.beau...@gmail.com>
wrote:
> Cool! I forgot to add: make sure that you also update ocaml-ffmpeg, there
> was a big there in how we set frame metadata.
> On Tue, Aug 24, 2021, 00:51 John Warburton <j...@johnwarburton.net> wrote:
>
>> On Tue, 24 Aug 2021 at 02:35, Romain Beauxis <romain.beau...@gmail.com>
>> wrote:
>>
>>> I just pushed the fix to pass liquidsoap's metadata down to ffmpeg
>>> filters! They are passed only when the `pass_metadata` parameter is set to
>>> `true`. By default, it only passes them to audio streams. I'm making the
>>> assumption that metadata mostly matters for audio streams where they may
>>> hold track title/artist/album etc.
>>>
>>> Curiously, the metadata sometimes flicks into life, but most of the time
my player reports "Unknown".
On the latest main git, my bodged function to insert metadata still works.
I wonder what could be causing that? Here is the FFmpeg filter chain and
surrounding functions, where "handle_metadata" is called on the stream
immediately before the FFmpeg filter creation.
In the "output.icecast" call, I also took out icy_metadata="false" (which
allows my function to insert the data instead of the output.icecast call).
def handle_metadata(m) =
print("************************METADATA*************************")
t = m["title"]
a = m["artist"]
ta = if t == "" then "Unknown title" else t end
aa = if a == "" then "Unknown artist" else a end
print("Title is \"" ^ ta ^ "\"")
print("Artist is \"" ^ aa ^ "\"")
icy.update_metadata(host="127.0.0.1", port=8000, password="[PRIVATE]",
mount="audio.aac", [("title", ta), ("artist", aa)])
icy.update_metadata(host="127.0.0.1", port=8000, password="[PRIVATE] ",
mount="audio-comp.aac", [("title", ta), ("artist", aa)])
icy.update_metadata(host="127.0.0.1", port=8000, password="[PRIVATE] ",
mount="audio-hifi.aac", [("title", ta), ("artist", aa)])
end
_______________________________________________
Savonet-users mailing list
Savonet-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-users
