On 12/25/2010 09:48 PM, Gerardo Fernandez wrote:
> Hi all,
>
> when exporting games to HTML/JS, the line with the names of the
> players gets truncated and only white's surname appears.
>
> Commenting line 753 in misc.tcl (set l [lindex $this_players 0]) seems
> to solve it, but I'm not sure about possible side effects of doing it.
It was me who made this change in the code (in rev. 1.17). I will check
once more after my holiday (and before the coming release!), but I
somehow cannot confirm what you see (my test this morning succeeded).
Originally line 753 was not there, and the next line referred to
$this_players instead of $l. The reason for the change is that
$this_players is actually a list-of-strings-type (with one string
element). The /puts/ of this list led to a pair of {}'s around the
player names in the game header on the right hand side of the html page.
Got it?
The intention of line 753 is to transform the list in a normal string;
maybe the approach I chose is not safe under all circumstances... Note
that I am not a Tcl expert - so open for any better solution...
E.g. setting $l to the first element of $players (such that it has the
same value as during the first iteration of the foreach loop in line
731) may work pretty well as well.
Are you on CVS?
Is there anything special about the names of your players? Some special
characters in there, that could lead to string flushing while encoding
to html?
In the left part of the html page there is a drop-box below the board.
Are the player names correct in this drop box?
Anyone else? Please try both exporting a single game and multiple games...
The side effect of commenting this line (and still use $l on the next
one) is that game header rendering (in the right hand side of the html
output) goes wrong if you export multiple games. You may want to try
this out. You see, the $l that is used on the next line is the one
resulting from the foreach loop in lines 731 etc; so if you export
multiple games it will be the last one (instead of the first one) from
the set, that is shown as a starter. Of course, you will not notice any
difference if you export only a single game.
Cheers,
Joost.
> What is the purpose of that line? Can it be safely commented out?
>
------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Scid-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/scid-users
