On 12/26/2010 07:28 AM, Joost 't Hart wrote:
> Got it!
>
> And it is a bug that I solved incorrectly...
>
> In misc.tcl there are two calls of the toHtml procedure that we're
> talking here.
>
> One in 583 ("export filter game(s)") and one in 619 ("export current game").
>
> Now notice the difference in the two lines just above these lines.
>
> In 618, $players is set to a list containing a single simple string.
> In 582, $players is set to a simple string.
>
> Furthermore, notice that in 619, $players is used both as the game list
> and the initial game. This led to the {}'s I saw. In a compiled language
> this would have been punished. It is this invocation that my change (at
> the wrong spot!) anticipated. You are taking the other route...
>
> The "fun" is that /lindex $var 0/ is an overloaded operation. If $var is
> a list it takes the first element; from a string it takes the first word
> (up to the first - indeed - space character). Tada!
>
> (and "hm hm sorry" that I did not notice this when I was working on this
> bit)
>
> Hence, here my suggestion for the solution:
>
> 1) In 619, change the _second_ occurrence of /$players/ into /[lindex
> $players 0]/ (as I did in 753)
> 2) In 754, change /$l/ into /$this_player/
> 3) Remove line 753
>
> Thanks for pointing this out!

Fixed in CVS.

> So, as far as testing is concerned, there are actually three use cases:
> 1) Export current game
> 2) Export filter games, with only a single game in the filter (this one
> I missed).
> 3) Export multiple filter games
>
> Cheers,
> Joost.
>
>
> On 12/26/2010 02:52 AM, Gerardo Fernandez wrote:
>> Hi, Joost,
>>
>> thanks for taking the time to answer.
>>
>> I hope to do some more tests, but the spaces are causing the problems for me.
>>
>> Using the CVS version both in Linux Mint and in Windows XP, the
>> dropdown list under the board appears ok, but the names of the players
>> on the right don't show correctly.
>>
>> For example, what should be "Paunovic, Dragan - Huerga Leache, Mikel"
>> is shown as "Paunovic," and "Huerga Leache, Mikel - Franco, Alejandro"
>> appears only as "Huerga".
>>
>
> ------------------------------------------------------------------------------
> Learn how Oracle Real Application Clusters (RAC) One Node allows customers
> to consolidate database storage, standardize their database environment, and,
> should the need arise, upgrade to a full multi-node Oracle RAC database
> without downtime or disruption
> http://p.sf.net/sfu/oracle-sfdevnl
> _______________________________________________
> Scid-users mailing list
> Scid-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/scid-users
>


------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Scid-users mailing list
Scid-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/scid-users

Reply via email to