On 06/17/11 15:44, f...@libero.it wrote:
Hello Fulvio!
> I pushed into the git repository the code for the new
> dockable "best tree games" window:
I fear I have to report some issues. First of all please
keep in mind not to break classical mode, this is
imperative.
Anyway, the first issue I see is the following:
----------------------------------------------------------------------
Error in startup script: invalid command name "ttk::bindMouseWheel"
while executing
"ttk::bindMouseWheel $w.glist "glist.ybar_ $w.glist""
(procedure "glist.create" line 49)
invoked from within
"glist.create $w.f2 "switcher""
(procedure "::windows::switcher::Open" line 37)
invoked from within
"::windows::switcher::Open "
invoked from within
"if { !$::docking::USE_DOCKING } {
if {$startup(switcher)} { ::windows::switcher::Open }
if {$startup(pgn)} { ::pgn::OpenClose }
if {$startup(gam..."
(file "./scid" line 150078)
X Error of failed request: RenderBadPicture (invalid Picture parameter)
Major opcode of failed request: 152 (RENDER)
Minor opcode of failed request: 7 (RenderFreePicture)
Picture id in failed request: 0x0
Serial number of failed request: 11807
Current serial number in output stream: 11889
----------------------------------------------------------------------
This stems from ttk::bindMouseWheel in l.1054 of
gamelist.tcl. Why do you use ttk:: instead of bindMouseWheel
which is used in all other places? I can easily resolve this
(resuting in an immediate crash of Scid) by removing ttk::
Next I get
----------------------------------------------------------------------
can't unset "::glistResized(.baseWin.f2.glist)": no such element in array
can't unset "::glistResized(.baseWin.f2.glist)": no such element in array
while executing
"unset ::glistResized($w)"
(procedure "glist.destroy_" line 15)
invoked from within
"glist.destroy_ .baseWin.f2.glist"
(command bound to event)
----------------------------------------------------------------------
immediately, if I try to open the database switcher (started
by default in my classic mode setup.)
If I ignore it and open a database and then try to fire up
the db switcher I get:
----------------------------------------------------------------------
bad window path name ".baseWin.c.f1.img"
bad window path name ".baseWin.c.f1.img"
while executing
"grid $w.c.f$i.img -row 0 -column 0 -rowspan 2 -padx 2 -pady 2"
(procedure "::windows::switcher::Refresh" line 16)
invoked from within
"::windows::switcher::Refresh"
(command bound to event)
----------------------------------------------------------------------
I even get this if I temporarily enable docking mode.
Finally I found that if I load a database, open the tree, go
to best games and scroll with the mouse wheel I get
----------------------------------------------------------------------
invalid command name "glist.ybar_ .treeBest1.glist"
invalid command name "glist.ybar_ .treeBest1.glist"
while executing
"{glist.ybar_ .treeBest1.glist} yview scroll 1 units"
(command bound to event)
----------------------------------------------------------------------
Please have a look at those issues :)
After all those problem reports, the new best games looks
nice. I also like the footnote markers showing sorting
criteria. If you set a new criterion, however, sometimes you
have to recalculate the column width for the marker not to
overlap with the heading. (See e.g. W/B-ELO, Length, Result)
I would however tidy it up a bit using smaller line spacing
like in the games list.
Probably one could reuse the widget for the games list.
--
Kind regards, / War is Peace.
| Freedom is Slavery.
Alexander Wagner | Ignorance is Strength.
|
| Theory : G. Orwell, "1984"
/ In practice: USA, since 2001
------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________
Scid-users mailing list
Scid-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/scid-users
