>[PATCH] Add rock-solid tooltip implementation
Hi, I'm glad to see that you are sending more and more patches. If possible I would like to invite you (and anyone who wishes to contribute significantly to Scid) to use a "Pull-Requests" workflow: http://www.codepool.biz/co-work-with-git-on-sourceforge-and-github.html Scid is multi-platform, but tck/tk has some annoying differences between versions of the library and across different operating systems: it is not uncommon to have bug reports related to a specific Linux distribution. To complicate matters, in Scid the code is not properly encapsulated and I have seen apparently innocuous changes that generated amazing side effects in other logically unrelated areas. To address this I usually try non-trivial patches on different operative systems: - Windows 8 64-bit with tcl/tk 8.6 - Windows XP 32-bit with tcl/tk 8.5 - A couple of VM Linux distros (one Debian based and one Red Hat-based). And for tcl/tk code I also have to manually grep each call to every function modified by the patch and verify that there are no "strange things". In conclusion, reviewing a patch like this one will take some time, and a "Pull-Requests" workflow is much tidier. Bye, Fulvio ------------------------------------------------------------------------------ _______________________________________________ Scid-users mailing list Scid-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/scid-users
