>I am also in favour of a merge/pull-request workflow. I now created a sf >account and put the commit in a separate branch tooltip-reimplementation >and created a merge-request for you. > Thanks.
> >For the linux part of the problem I would be willing to help building >things on various systems i.e. with the help of "compile farms" like >https://gcc.gnu.org/wiki/CompileFarm and automating the process with the >help of a build server like Jenkins. > I use travis-ci.org to automatically compile any Scid commits with clang 3.5 e 3.7, gcc 4.9 e 5.0 and Darwin 13.4.0 (Mac OS X). Unfortunately it does not help with regard to tcl/tk code. For example i tried briefly the tooltip patch and it breaks the "tree mask": hoovering over a move with a comment triggers "Error: missing close-bracket". It's probably a very trivial bug, but there are also other quirks: - the tooltip is displayed (for the same button) sometimes below and sometimes above the mouse cursor - sometimes the tooltip "blink" (it appears for 2ms, then disappears for 2ms and then works correctly) - the tooltip text is too small :) The tcl/tk library do not respect Windows high-dpi settings: at least, with the current code, i can manually increase the font size with Options->Fonts->Tiny I believe this example describe well the problems i mentioned before: you have a specific OS (windows) problem and a tcl bug in a semi-unknown feature that is apparently unrelated with the code modified by the patch. That's why, in my opinion, standard code should be used when possible. You adapted the code from here: http://wiki.tcl.tk/1954 but maybe it's better to use (if possible, i do not know the license) the tklib code? https://core.tcl. tk/tklib/doc/trunk/embedded/www/tklib/files/modules/tooltip/tooltip.html With that it's possible to replace the whole tooltip.tcl file with this 9 lines: package require tooltip namespace eval ::utils::tooltip { proc Set { button msg } { tooltip::tooltip $button $msg } proc SetTag { text_widget msg tag } { tooltip::tooltip $text_widget -tag $tag $msg } } Two final notes: - the ability to customize the tooltip font is a must. - "when entering an element with a tooltip the tooltip pops up even when the mouse has left the element in the meantime" is a bug caused by the horrible lines 1229-1235 in main.tcl Can you please work a little more on the tooltip code and send another patch? Thanks, Fulvio ------------------------------------------------------------------------------ _______________________________________________ Scid-users mailing list Scid-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/scid-users
