Hi Steve,
I think you forgot to add the option to the foreach list of variables
used when exiting to save to options.dat. Also maybe a typo with
missing ")" wrt info exists?
Again not that much familiar with tcl and scidvspc inner plumbing, but
this seems to be needed, based on my limited checking here.
Attaching a patch wrt same.
On Mon, Dec 9, 2024 at 1:22 PM Steve A <stevena...@gmail.com> wrote:
>
> Ok Hanish... I applied one patch, but not the color one.... Too many minor
> colour options around.
> I made some other tweaks too. Now you can just set analysis(boardSeqNumColor)
> in an init file, or in the gui somewhere.
>
> Ding made a classic Ding blunder last night!
>
> cheers.
>
>
> On Sun, Dec 8, 2024 at 7:20 PM C Hanish Menon <hanish...@gmail.com> wrote:
>>
>> Hi Steve,
>>
>> I feel these two patches will make the moves visualisation feature
>> more legible and flexible to end users
>>
>> These include
>>
>> 1. make the move number font bold
>>
>> 2. make the move arrow longer specifically wrt boardVisualiseMoves
>>
>> 3. pick the move number font color from a new option, which the user
>> can control, which inturn by default set to red
>> Picking it from GlobalTextColor forces user to globally change the
>> text color everywhere, when many a times because of the chess set
>> used, one may want to change the color only for the movenumber shown
>> on the analysis board.
>>
>> NOTE: Something seems to have changed wrt avoiding partial PVs from
>> the engine overriding previous depth full pv visualisation, I need to
>> see why the latest subversion release/eviision has changed this
>> behaviour later.
>>
>> On Sun, Dec 8, 2024 at 12:37 PM Steve A <stevena...@gmail.com> wrote:
>> >
>> > Yeah, it wasn't too legible yesterday. I reverted the num colour to
>> > default text colour, and tweaked the arrow head. The blue is just what I
>> > have set as options-colours-enginearrows. I'll have to document it all.
>> >
>> > Cheers
>> >
>> > On Sunday, December 8, 2024, C Hanish Menon <hanish...@gmail.com> wrote:
>> >>
>> >> Hi Steve
>> >>
>> >> Was modifying things from yesterday's release, to send patch to you. But
>> >> will checkout the new revision from SVN before sending any patch.
>> >>
>> >> Also looking at the image, I can see a reason why there may be some
>> >> differences in what we have been saying and inturn trying to achieve wrt
>> >> visualisation themeing around this feature
>> >>
>> >> For me the default scidvcpc setup shows a more fancy chess set and also
>> >> the lines are black with text also black on top & also shorter arrow
>> >> lines, in your yesterday's commit. All of which makes the move
>> >> visualisation theme (predefined line colour, line length) you had forced
>> >> ;) in yesterday's revision non legible.
>> >>
>> >> I was about to submit a patch with blue longer lines and red text on top
>> >> and also changing to bold font. Those changes were to make things more
>> >> legible.
>> >>
>> >> However from your image it appears like now you have also changed the
>> >> lines to blue & made it longer. So that should potentially resolve the
>> >> confusion & conflict in our patches
>> >>
>> >> PS: yes agree the match is favouring Ding now, given that the cost of
>> >> risk is lot more now. However it's Gukesh who is trying to add some spice
>> >> into the mix. Given their positions wrt championship both their
>> >> behaviours is understandable. Here in India, in general, we root for
>> >> Gukesh, but equally love Ding :)
>> >>
>> >>
>> >> On Sun, Dec 8, 2024, 08:48 Steve A <stevena...@gmail.com> wrote:
>> >>>
>> >>> Ok, Hanish's feature is looking nice - nearly finialized - and is
>> >>> included in subversion now.
>> >>> (I've modified it a bit, so not exactly how Hanish envisioned it, sorry
>> >>> mate).
>> >>> Check out svn and after installation select "Show Board" and
>> >>> "Sequential" in the tools->Analysis window.
>> >>> Screenshot attached. Cheers, S.A.
>> >>>
>> >>>
>> >>> On Sun, Dec 8, 2024 at 1:07 PM Steve A <stevena...@gmail.com> wrote:
>> >>>>
>> >>>> Ok... I sorted out some issues today. Control+Wheelmouse will resize
>> >>>> the board now (hopefully... the focus/flow for these bindings is hard
>> >>>> to understand).
>> >>>> You're welcome to update help.tcl if you like... I haven't got around
>> >>>> to it yet.
>> >>>>
>> >>>> > 3. the reason why I had not used engineLineColor is to allow for the
>> >>>> situation where one can see the different 1st moves suggested by the
>> >>>> analysis engine (which uses engineLineColor, if I am not wrong) as
>> >>>> well as the move sequence wrt main pv
>> >>>>
>> >>>> Yeah... for sure. But i think it's better to keep them separate, rather
>> >>>> than having to zero the spinbox.
>> >>>>
>> >>>> > Because otherwise users will have to click the middle mouse button
>> >>>>
>> >>>> I agree, it's not a great UI element/design, having to use the middle
>> >>>> button.
>> >>>> But the default is settable in Tools->analysis config widget
>> >>>>
>> >>>> > PS: I have a background in computer science, rather I keep jumping
>> >>>> between things and languages based on what I am doing (like watching
>> >>>> the chess championship this time)
>> >>>>
>> >>>> Yes - very interesting championship isn't it ! :)
>> >>>> I have to say I'm going for Ding though, after the huge struggles he's
>> >>>> had the last couple of years. Gukesh certainly has the form this year,
>> >>>> but *maybe* his youth will be to his detriment this time... ? I guess
>> >>>> from your name you are Indian(?) and going for Gukesh :)
>> >>>>
>> >>>> regards, Steve
>>
>>
>>
>> --
>> Keep ;-)
>> HanishKVC
--
Keep ;-)
HanishKVC
Index: tcl/menus.tcl
===================================================================
--- tcl/menus.tcl (revision 3491)
+++ tcl/menus.tcl (working copy)
@@ -984,6 +984,7 @@
gameInfo(fullComment) gameInfo(showMarks) gameInfo(showMenu) gameInfo(showTool)
gameInfo(showMaterial) gameInfo(showFEN) gameInfo(showButtons) gameInfo(showTB)
analysis(mini) engines(F2) engines(F3) engines(F4) analysis(logMax) analysis(logName) analysis(maxPly) analysis(lowPriority) analysis(boardSize) analysis(boardType) analysis(showBoard) analysis(showEngineInfo) analysis(wrapPV)
+ analysis(boardSeqNumColor)
scidBooksDir scidBasesDir
::book::lastBook1 ::book::lastBook2 ::book::lastTuning ::book::sortAlpha
::book::showTwo ::book::oppMovesVisible ::gbrowser::size
Index: tcl/tools/analysis.tcl
===================================================================
--- tcl/tools/analysis.tcl (revision 3491)
+++ tcl/tools/analysis.tcl (working copy)
@@ -3746,7 +3746,7 @@
# Visualise moves sequence on a board
# Get text widget fg color in case we are using a custom foreground S.A.
-if {![info exists analysis(boardSeqNumColor]} {
+if {![info exists analysis(boardSeqNumColor)]} {
set analysis(boardSeqNumColor) [.splash.t cget -foreground]
}
_______________________________________________
Scidvspc-users mailing list
Scidvspc-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/scidvspc-users
