On Thu, Jan 05, 2012 at 08:33:01AM -0800, Jacob VanderPlas wrote: > Here's a small example I coded up that shows how I envision including > multiple distance metrics in BallTree
> https://gist.github.com/1565998 > The idea is that you create functions to compute distance which expose C > function pointers, so that the ball tree cython code can call these > without python overhead. I'd be curious to hear peoples' thoughts You are cimporting malloc and free. I have a personnal difficult relationship with those two old friends. However, it seems not to be used in the code. I just wanted to check. Why do you have a not implemented method? I would favor no method at all in this case. Also, I don't like the 'tmp' attribute of the cv_matrix structure: I must confess that I don't know what it mean (same thing for dist_params.VI). But I think that the fact that I am fussing on such minor details really means that I think that the general design is good. What do others think? Gaël ------------------------------------------------------------------------------ Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex infrastructure or vast IT resources to deliver seamless, secure access to virtual desktops. With this all-in-one solution, easily deploy virtual desktops for less than the cost of PCs and save 60% on VDI infrastructure costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
