Gael Varoquaux wrote: <snip> > You are cimporting malloc and free. I have a personnal difficult > relationship with those two old friends. However, it seems not to be used > in the code. I just wanted to check. > I initially used malloc and free, but settled on the `tmp` pointer to avoid this (see below). These imports can be removed. > Why do you have a not implemented method? I would favor no method at all > in this case. > Just a place-holder. I would plan to implement this later, if the general framework seems sound. > Also, I don't like the 'tmp' attribute of the cv_matrix structure: I must > confess that I don't know what it mean (same thing for dist_params.VI). > In computing the mahalanobis distance, a temporary storage array is needed. To avoid repeated allocation within the distance C-function (and to avoid the need for malloc/free), I pre-allocate this temporary array via numpy and store the pointer in the parameter structure. A more informative name for 'tmp' would probably help, as well as some in-line documentation :) > But I think that the fact that I am fussing on such minor details really > means that I think that the general design is good. What do others think? > > Gaël > Thanks for the feedback, Gael Jake
------------------------------------------------------------------------------ Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex infrastructure or vast IT resources to deliver seamless, secure access to virtual desktops. With this all-in-one solution, easily deploy virtual desktops for less than the cost of PCs and save 60% on VDI infrastructure costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
