Hello everyone,

As it's Valentine's day, I thought I would make a present to sklearn 
contributors because I love their work!

I noticed a small typo in the __init__ method of the MiniBatchKMeans 
class 
(https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/cluster/k_means_.py#L1015):

current line:

self.init_size = batch_size if init_size is None else 3 * init_size

should be:

self.init_size = 3 * batch_size if init_size is None else init_size


I often find myself wondering what is the best way to report or correct 
such small bugs? Is sending a mail like this to the mailing list the 
preferred way?

It happens, sometimes, that I find mistakes that are easy to correct 
(e.g. typos in docs) and, as they are really small, I generally don't 
"dare" send a "spam" to bother everyone (today being the exception ;-)) 
or don't have the courage to properly correct it because I'm not 100% 
familiar with the project's coding guidelines, dev tools, etc.

In addition, like everyone else, I'm quite busy and don't have much free 
time on my hands to dedicate to this (writing this e-mail cost me my 
daily coffee-break ;-)).

Consequently, I selfishly correct the problem for my own use in a 
quick-and-dirty manner and that's it. That's how I end up having a 
severely hacked version of sklearn that prevents me even more from 
collaborating...

Note, that this is general regarding my (sadly one-sided) relationship 
with open source projects. My guilty conscience is beginning to get 
heavier...

Therefore, I'd like to know the means "gurus" fancy most, both in 
general but also more specifically for sklearn, in order to have their 
user of the "busy/lazy, grateful & leeching" type contribute in a 
relatively painless way for them? I believe the number of such users is 
proportional to how easy it is to use the library, so with sklearn I'm 
sure there are more than a few!

Sorry for being a bit off topic. Maybe it's only me, but it's a question 
that bugged me for a while now.

Cheers,

Adrien


------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Scikit-learn-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/scikit-learn-general

Reply via email to