Hi Adrien. > As it's Valentine's day, I thought I would make a present to sklearn > contributors because I love their work! > Thank you :) > I noticed a small typo in the __init__ method of the MiniBatchKMeans > class > (https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/cluster/k_means_.py#L1015): > > current line: > > self.init_size = batch_size if init_size is None else 3 * init_size > > should be: > > self.init_size = 3 * batch_size if init_size is None else init_size > > > I often find myself wondering what is the best way to report or correct > such small bugs? Is sending a mail like this to the mailing list the > preferred way? > > Submitting a pull request on github is the preferred way. This means one of us only has to click the "merge" button to correct it.
> It happens, sometimes, that I find mistakes that are easy to correct > (e.g. typos in docs) and, as they are really small, I generally don't > "dare" send a "spam" to bother everyone (today being the exception ;-)) > or don't have the courage to properly correct it because I'm not 100% > familiar with the project's coding guidelines, dev tools, etc. > > Don't worry about sending a pull request. If something is not 100% ok, you'll get feedback and you'll get used to the coding guidelines. > In addition, like everyone else, I'm quite busy and don't have much free > time on my hands to dedicate to this (writing this e-mail cost me my > daily coffee-break ;-)). > I can completely understand. I think the best way would then be to submit an issue. This way it is very easy to keep track of things and even if no-one has time at the moment, someone will come back to it eventually. Have a nice valentines day and thank you for your help in correcting spelling mistakes :) (That's how I got started with this project about half a year ago ;) Cheers, Andy ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
