2012/7/26 Jake Vanderplas <[email protected]>: > Hi, > On 07/26/2012 02:37 AM, Gael Varoquaux wrote: > <snip> >> Awesome! I just want to thank the team: after I sent this email a lot of >> different people pitched in and we are now with a coverage level that is >> above where we were a couple month ago: >> https://jenkins.shiningpanda.com/scikit-learn/job/python-2.7-numpy-1.5.1-scipy-0.10.0 > I noticed that a big chunk of remaining non-coverage is due to the > arpack backport from scipy. An easy fix would be to simply copy the > scipy arpack test suite to scikit-learn. I tried this quickly, and > noticed a few errors related to scipy ticket 1515 > (http://projects.scipy.org/scipy/ticket/1515), which has since been > fixed in scipy master. > > If we think that it's worth updating our arpack clone and copying the > test suite from scipy, I'd be happy to prepare a PR. It would make our > arpack port more stable and increase our test coverage by ~500 lines, > which is a bit more than 2% in the Jenkins statistics.
That would be great, in particular to trust that no bug was introduced during the backport procedure. -- Olivier http://twitter.com/ogrisel - http://github.com/ogrisel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
