Hi James. Thanks for the PR. I thinks so far we avoided changing LibSVM and tried to get patches in upstream. Afaik, this hasn't succeeded so far. The cases I am thinking of is me trying to get the chi2 kernel in and Lars cleaning up some of the code.
As LibSVM seems to be very conservative wrt. features and patches, I think we should reconsider our policy and accept your modifications. Can you give some insights into why this check is necessary and in what kind of situations LibSVM fails to converge? I guess it uses the duality gap for convergence. Is is the case that this is not a good measure sometimes? Cheers, Andy ------------------------------------------------------------------------------ How fast is your code? 3 out of 4 devs don\\\'t know how their code performs in production. Find out how slow your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219672;13503038;z? http://info.appdynamics.com/FreeJavaPerformanceDownload.html _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
