Hi Doug, thanks for this! I'm still a little shaky with git, I was wondering if people could advise how to manage the set of libsvm patches? The thing that comes to my mind is:
1. Fork Doug Coleman's libsvm tree for now into the scikit-learn organization (If we hear from Chih-Jen Lin, we can edit a few .git/config links to use his version instead. Unless someone on this list knows Chih-Jen Lin personally, we may not get a response from him at all.) 2. Apply the current sklearn diff from libsvm as a single monolithic commit to this new scikit-learn/libsvm fork. We will rebase this on libsvm's master periodically. 3. Add scikit-learn/libsvm as a submodule at it's current location: sklearn/svm/src/libsvm so that it does not disrupt the current file hierarchy. 4. Add a Makefile command that updates & syncs the git submodule, and possibly modify some of the existing Makefile commands to trigger that update before executing. If that's cool with people, then I would split my PR into one PR against scikit-learn/libsvm, and one PR against scikit-learn/scikit-learn that has the Python and Cython stuff. On Wed, Sep 26, 2012 at 5:40 PM, Doug Coleman <[email protected]> wrote: > I put up a copy of the libsvm-3.12 release on my github. For some > reason, ``make lib`` in the main directory or ``make`` in python/ > doesn't work out of the box, so I made a patch that works on my > system. > > https://github.com/erg/libsvm > > This is not a hostile fork, just a way to get some version control > onto some changes. Hopefully the libsvm people use git and could just > cherrypick the patches they like someday. Hopefully I'd just clone > their next release. > > Anyway, you can submit pull requests against it. If someone else would > rather do it, let me know, or if you want admin permissions, let me > know. > > Cheers, > Doug > > On Wed, Sep 26, 2012 at 2:30 PM, Gael Varoquaux > <[email protected]> wrote: >> Hey Joseph, >> >> Fair enough with regards to your points about a fork being considered as >> aggressive. Thanks a lot raising this point. I guess that I was more >> thinking of fork in terms of version control rather than in terms of >> creating a parallel project. I have grown used to fork being useful >> things :). >> >> Also, I am worried that a collection of patches will bitrot, and my >> immediate thought is to put them in a git, just to make sure that history >> is conserved. >> >> Of course, my thoughts reflect very much that I am used to working with >> open version-control project and distributed version control, which is >> not the case here. >> >> Anyhow, both situations, the collection of patches and the fork, are >> suboptimal situations. >> >> Thanks for your thoughts, >> >> Gaël >> >> On Wed, Sep 26, 2012 at 02:14:27PM -0700, Joseph Turian wrote: >>> >> If sklearn will be maintaining a patch set against libsvm, this patch >>> >> set should be available to non sklearn users too. >> >>> > I reckon you are volonteering to maintain a fork of libsvm? That's very >>> > good news, the community definitely needs this badly. >> >>> I was considering the idea of a fork, but I think it might be premature. >> >>> Everyone seems to agree that it would be great if the patches merged >>> upstream. >> >>> If the maintainers have been unwilling to merge patches, then they >>> might not merge the patches this time around. >> >>> If you fork the project, that might be taken as an aggressive move and >>> they will be unwilling to work together with the maintainers of the >>> fork. >> >>> My thought was that releasing a patch set, but not actively >>> maintaining it, and following it up with an email to maintainers: >>> "We'd like to see our patch set merged into libsvm core code", then >>> there is some pressure on libsvm to merge the patches but not an >>> aggressive amount (like forking). >> >>> Just my thoughts. >> >>> Joseph >> >>> ------------------------------------------------------------------------------ >>> How fast is your code? >>> 3 out of 4 devs don\\\'t know how their code performs in production. >>> Find out how slow your code is with AppDynamics Lite. >>> http://ad.doubleclick.net/clk;262219672;13503038;z? >>> http://info.appdynamics.com/FreeJavaPerformanceDownload.html >>> _______________________________________________ >>> Scikit-learn-general mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/scikit-learn-general >> >> -- >> Gael Varoquaux >> Researcher, INRIA Parietal >> Laboratoire de Neuro-Imagerie Assistee par Ordinateur >> NeuroSpin/CEA Saclay , Bat 145, 91191 Gif-sur-Yvette France >> Phone: ++ 33-1-69-08-79-68 >> http://gael-varoquaux.info http://twitter.com/GaelVaroquaux >> >> ------------------------------------------------------------------------------ >> How fast is your code? >> 3 out of 4 devs don\\\'t know how their code performs in production. >> Find out how slow your code is with AppDynamics Lite. >> http://ad.doubleclick.net/clk;262219672;13503038;z? >> http://info.appdynamics.com/FreeJavaPerformanceDownload.html >> _______________________________________________ >> Scikit-learn-general mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/scikit-learn-general > > ------------------------------------------------------------------------------ > How fast is your code? > 3 out of 4 devs don\\\'t know how their code performs in production. > Find out how slow your code is with AppDynamics Lite. > http://ad.doubleclick.net/clk;262219672;13503038;z? > http://info.appdynamics.com/FreeJavaPerformanceDownload.html > _______________________________________________ > Scikit-learn-general mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/scikit-learn-general ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
