2012/9/27 Doug Coleman <[email protected]>: > 1) scikit's libsvm checkin is currently version 300. The last release > was in April and the version is 312. Are there plans to use the newer > version? The svm_node struct changed, so it's not as trivial as > dropping in the files.
What are the major benefits? > 2) libsvm comes with a ctypes binding. What if scikit contributed a > cython binding that was in the libsvm project? Then scikit could just > use the libsvm cython module for implementing fit(), predict(), etc. That would mean that any changes to this Cython binding would have to be contributed upstream, as you already suggested. > 4) I opened another issue on my github of some compiler warnings from > the clang++ compiler. It turns out that there are a lot of calls to > malloc where the return pointer is unchecked. So basically the library > can crash at any time. Someone already offered to make a nontrivial > patch using std::vector and new to fix it. How do we want to proceed? > What's the strategy to merge the change with libsvm and the scikit > project? > > https://github.com/erg/libsvm/issues/1 That was me :) I'm quite swamped ATM, but I did intend to refactor our LibSVM bindings sometime in the near future (preferably before the next release). I intend to decouple all the prediction code from LibSVM and rewrite it in Python/Cython, just like I did for our Liblinear binding. I'm not sure what to do with the training code yet, but after looking at it again, I'm more and more enclined to go with Mathieu's suggestion of maintaining our own version. The second thing on my list would be to check how much of the code can go away. -- Lars Buitinck Scientific programmer, ILPS University of Amsterdam ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
