2012/10/15 Gael Varoquaux <[email protected]>: > Hi, > > I just had to do a little dance to make the tests robust on my box by > reinstantiating a RandomizedPCA object each time that I wanted to fit [1]. > Indeed, because in fit, for RandomizedPCA, we do: > > self.random_state = check_random_state(self.random_state) > > calling fit twice does not give the same result. > > While the above pattern may be useful in a method that does sampling and > needs results at each call, I don't think that it is useful in the case > of RandomizedPCA. I suggest that I should simply change it to do: > > random_state = check_random_state(self.random_state) > > What do people think?
+1. We also need to document this pattern and make sure that we make the codebase consistent once we agree on: https://github.com/scikit-learn/scikit-learn/issues/1108 -- Olivier http://twitter.com/ogrisel - http://github.com/ogrisel ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
