2012/10/15 Gael Varoquaux <[email protected]>: > On Mon, Oct 15, 2012 at 12:30:51PM +0200, Olivier Grisel wrote: >> > What do people think? > >> +1. > > OK, done in 8141cb1! > >> We also need to document this pattern and make sure that we make >> the codebase consistent once we agree on: > >> https://github.com/scikit-learn/scikit-learn/issues/1108 > > Indeed. In general I favor this pattern, however in specific cases (e.g. > sampling) it can pose problems (that can be aleviated using a shadow > attribute random_state_ or _random_state). > > I suggest that for now we apply it everywhere it is uncontroversial.
+1 -- Olivier http://twitter.com/ogrisel - http://github.com/ogrisel ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
