2013/9/23 Luca Cerone <luca.cer...@gmail.com>: > Thanks Olivier! > Since I am new to github, has the pull request been added to the master, or > are you waiting for it to be improved before merging?
The pull request is still open, hence not merged yet. The review is still underway. Issam: if you think it's ready for final review before merge your should change the [WIP] marker (that stands to work in progress) to [MRG] to tell the reviewers that you are waiting for their input to proceed. Otherwise one will assume that there are still unimplemented or untestested or undocumented areas that you are working on. Also you can update the description's TODO list and use angle brackets "[ ]" to make github turn them into tick boxes. For instance: - [x] this is done - [ ] this is left to do -- Olivier http://twitter.com/ogrisel - http://github.com/ogrisel ------------------------------------------------------------------------------ LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk _______________________________________________ Scikit-learn-general mailing list Scikit-learn-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
