Thanks @Luca happy to help. :) Thanks for the heads up @Olivier. I'm finishing up the necessary test cases to get a safe coverage rate. I will then change the pull request status to MRG :).
Thanks. On 9/23/2013 3:45 PM, Olivier Grisel wrote: > 2013/9/23 Luca Cerone <luca.cer...@gmail.com>: >> Thanks Olivier! >> Since I am new to github, has the pull request been added to the master, or >> are you waiting for it to be improved before merging? > The pull request is still open, hence not merged yet. The review is > still underway. > > Issam: if you think it's ready for final review before merge your > should change the [WIP] marker (that stands to work in progress) to > [MRG] to tell the reviewers that you are waiting for their input to > proceed. Otherwise one will assume that there are still unimplemented > or untestested or undocumented areas that you are working on. > > Also you can update the description's TODO list and use angle brackets > "[ ]" to make github turn them into tick boxes. For instance: > > - [x] this is done > - [ ] this is left to do > ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk _______________________________________________ Scikit-learn-general mailing list Scikit-learn-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
