Philippe Lhoste:
> BTW, I took a look at LexSQL.cxx, and I wasn't too happy to see it
> inefficiently repeating the tests in DEFAULT state. I tried to hack it,
> without satisfying result, so I rewrote it using the brand new version
> of the CPP lexer.
This sort of update is very hard to review as it mixes up
substantive changes, mechanism changes and formatting changes. One
thing that worries me is "MySQL requires a space or control char after
-- ... Perhaps we should enforce that". The lexer currently handles
PL/SQL (although that isn't well documented) which is a language
defined by Oracle that looks a lot like Ada with "--" introducing
comments. If MySQL is different enough to require different handling
here then it needs to have an option to enable this behaviour.
Breaking Oracle compatibility would not be a good idea and that
comment makes me wonder if there are changes that are not compatible
with PL/SQL. The "if (ch == 'i' || ch == 'b' || ch == 'e' || ch ==
'l') {" code appears to be an overly fragile optimisation which will
probably break if a keyword is in upper case although I haven't
analysed the code enough to be sure.
It may be an idea to tell me what substantive changes you want and
I'll try to apply them. Then when that code looks OK, the other
changes can be examined.
Neil
_______________________________________________
Scintilla-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scintilla-interest
