Robert Roessler:
ScintillaGTK(1995):
"empty controlled statement found; is this the intent?"
This could be easily fixed by removing the IsUnicodeMode() test as a
separate "if" statement and placing it at the front of the following
[conditionally compiled] "if" as "!IsUnicodeMode() && ". This would
have the added benefit of not executing code we really don't need to.
OK. This code should no longer be executed under GTK+ 2.x as the
gtk_im_context_filter_keypress call should handle all input.
PlatGTK.cxx(2286):
PlatGTK.cxx(2359):
PlatGTK.cxx(2367):
PlatGTK.cxx(2391):
"forcing value to bool 'true' or 'false' (performance warning)"
Those lines don't look like candidates for that warning in the copy
I'm using and I don't see them with VC7 or VC8 although I only have
the free version of VC8 so maybe it skimped on warning messages.
Possibly you have something turned on that isn't in
scintilla/gtk/scintilla.mak.
These could all just have "!= FALSE" appended and everyone would be happy.
Sounds safe, so go ahead.
Neil
_______________________________________________
Scintilla-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scintilla-interest
