Neil Hodgson wrote:
- the buffer flags isDirty and useMonoFont has been encapsulated within
a buffer variable and controlled by enum flags
Grouping all these into a bit set makes it too easy to incorrectly
set multiple states. ... Code that uses bitsets is also longer with extra
boolean
operators.
I've reversed my changes.
The biggest problem ... is that ProcessExecute ... is now modifying the
current buffer
I've been considering this for a bit. You are quite correct but I think
that storing the name of the buffer within a job is not sufficient. The
job that contains the flag that must be queried in order to assign
isBuilt would not exist by the time the IDM_FINISHEDEXECUTE code runs.
I've noticed that I am not deleteing the job object within
ProcessExecute(). I would like to:
- add a variable exitstate to the job class
- return the job as a void * instead of the exitstate
This way the IDM_FINISHEDEXECUTE code can get the exit state and build
flags.
I know I will not see your reply for some time, so I'll make a backup
and try this anyway.
April
--
So, when are you going to celebrate National Procrastination Day?
_______________________________________________
Scite-interest mailing list
Scite-interest@lyra.org
http://mailman.lyra.org/mailman/listinfo/scite-interest
