April White: > The SciTEWin::ProcessExecute() method currently pops a job off the > queue, and I've modified IDM_FINISHEDEXECUTE to receive the job as a > parameter via lparam. I have not altered anything to store the buffer > name so far, but the new code is working. > > Oh, I am also planning on on having IDM_FINISHEDEXECUTE delete the job > object.
I was thinking more like encapsulating this inside the JobQueue. Sending void*s through SendMessage is sometimes a necessary evil but it should be avoided when easy to do so. I suppose it is OK here. > I think that is what you are suggesting. BTW, which is a 'better' means > of assigning the buffer name to the job object: > 1. adding a parameter to AddCommand(), or > 2. utilizing CurrentBuffer() within AddCommand() - this absolutely > depends on the buffer being unchanged between the time the AddCommand() > is called and the job object is created I can't see there being any possibility of switching buffers between the start of the call to AddCommand and creating the job object. The parameters dialog is modal when displayed for a command so doesn't allow the user to switch buffers. Actions from the execute queue shouldn't affect the current buffer. I suppose there could be an OnFinishedExecute Lua event that the user could use to switch to a particular buffer such as the buffer containing an error but there isn't any such event now. Neil _______________________________________________ Scite-interest mailing list [email protected] http://mailman.lyra.org/mailman/listinfo/scite-interest
