April White wrote:
I think I'll revise things again :-)
I'll remove 'CurrentJob()' and add 'CurrentJobFlags()' and
'CurrentJobBufferPath()'
The two would be initialized within the CanExecute() code, returning
copies of the respective values.
JobQueue::CurrentJobDirectory has a small vulnerability since it
doesn't lock and copying a FilePath involves allocations.
I was about to say you were worrying to much, because the internal
variable is only assigned within GetNextJob(), but I recalled that it
is initialized within JobQueue::Clear(), so I agree that the variable
should be locked. Additionally, since GetNextJob() is only called
from within CanExecute(), I've made it a private method
I've revised the code as above and uploaded it as
http://www.scintilla.org/aprilw/scite-april-2005-12-31.zip
ttfn
April
--
Get a new car for your spouse. It'll be a great trade!
_______________________________________________
Scite-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scite-interest
