April White: > I was about to say you were worrying to much, because the internal > variable is only assigned within GetNextJob(), but I recalled that it > is initialized within JobQueue::Clear(), so I agree that the variable > should be locked.
Its also a matter of being defensive in case the code is changed in the future. I am being pickier with your code than with other changes to SciTE and even my own code for tool execution and thats because it is threading code and also a consequence of having 2 sets of eyes looking at it. My execute thread code would have been better if it had seen more review. > I've revised the code as above and uploaded it as > http://www.scintilla.org/aprilw/scite-april-2005-12-31.zip Some minor edits for warnings: ..\src\JobQueue.cxx(128) : warning C4800: 'int' : forcing value to bool 'true' or 'false' (performance warning) timeCommands = props.GetInt("time.commands") != 0; SciTEWin.cxx(456) : error C2440: 'reinterpret_cast' : cannot convert from 'LPARAM' to 'long' This one can be a static_cast as its just int to int. reinterpret_cast is there for when you are being evil, turning ints into pointers or similar, which is why there are 389 in Scintilla and SciTE. DWORD exitcode = static_cast<long>(lParam); [from an earlier mesage] > I've also included in the zip file a new makefile that is meant to be > placed in the folder above scite & scintilla. It is designed to detect > whether it is windows or gtk and then calls the makefile for the > appropriate subfolder. There isn't really a folder above Scintilla and SciTE from a distribution point of view: I don't want to define Scintilla and SciTE as subdirectories of a new distribution directory. There was very strong negative feedback when distributing archives with files in the top level: people want archives that have component directories at the top level so they can be safely expanded into a directory without mixing distribution files with the files already in that directory. Neil _______________________________________________ Scite-interest mailing list [email protected] http://mailman.lyra.org/mailman/listinfo/scite-interest
