Vladimir Kotal wrote: > Vladimir Kotal wrote: >> Hi all, >> >> Based on feedback from Dan Price, I've changed webrev.sh a bit to make >> it more pleasant to work with (in terms of webrev upload) and to fix 2 >> small bugs. >> >> webrev is here: >> http://cr.opensolaris.org/~vkotal/webrev-better_upload.onnv/ > > I know everyone is busy with more funny/interesting stuff but this one > still needs some review.
Have you tested all of the output paths? It seems like you're using trailing spaces inconsistently, such that some messages will not have spaces in between them? What testing did you do for the remote target specification validation? Does scp not have a trailing-slash problem like rsync? (Ie it seems like webrev should be using "$WDIR/*" instead of "$WDIR" as the src arg?) Seems like lines 349 and 354 could be rolled together. Aren't you losing the return code from ssh_upload now, on line 375-378? --Mark
