Mark J. Nelson wrote:

<snip>

>> Up-to-date webrev against ON clone is here:
>>   http://cr.opensolaris.org/~vkotal/webrev-better_upload.onnv.final/
> 
> The new line 276 isn't very informative about what the parenthesized 
> number means.  (Ie the number of args received when 1 was expected.)

I removed the number since and adjusted the error message a bit.

> 342-345: can this really happen?

Only during development (like the above) if the function is called with 
no argument. I found it quite helpful.

> No other comments.
> 
> Sorry for the delay.  You'll have a trivial merge with Salo's recent 
> changes.

No problem. Merged and refreshed.

Thanks,


v.

Reply via email to