Richard Lowe wrote:
> Hey all,
>
> A webrev is available for prelim code review:
>
> http://cr.opensolaris.org/~richlowe/scm-review_90
>
> We'd appreciate code review comments from anyone inclined to provide
> them, but scm-migration folks especially, at the moment.
>
> Deadline for comments is Friday May 29th.
>
> As the name suggests, this is against onnv_90. The comments in the
> file list are reconstructed from my notes and bug comments. The file
> list is http://cr.opensolaris.org/~richlowe/scm-review_90/active.list
> If you see problems with it, please do point those out too.
these should have a 2008 copyright date:
usr/src/tools/onbld/Checks/Cddl.py
usr/src/tools/onbld/Checks/CStyle.py
usr/src/tools/onbld/Checks/Comments.py
usr/src/tools/onbld/Checks/Copyright.py
usr/src/tools/onbld/Checks/DbLookups.py
usr/src/tools/onbld/Checks/HdrChk.py
usr/src/tools/onbld/Checks/Keywords.py
usr/src/tools/onbld/Checks/Makefile
usr/src/tools/onbld/Checks/Rti.py
usr/src/tools/onbld/Checks/__init__.py
usr/src/tools/onbld/Makefile
usr/src/tools/onbld/Scm/__init__.py
usr/src/tools/onbld/__init__.py
usr/src/tools/onbld/hgext/Makefile
usr/src/tools/onbld/hgext/__init__.py
usr/src/tools/scripts/cddlchk.1
usr/src/tools/scripts/cddlchk.py
usr/src/tools/scripts/copyrightchk.py
usr/src/tools/scripts/cstyle.pl
usr/src/tools/scripts/hdrchk.1
usr/src/tools/scripts/hdrchk.py
usr/src/tools/scripts/jstyle.pl
usr/src/tools/scripts/rtichk.py
usr/src/tools/scripts/webrev.1
usr/src/tools/scripts/wx2hg.1 (.TH line)
in usr/src/tools/onbld/Scm/Version.py:
57 (englishify(GOOD_VERSIONS),
wtf?!?! :-)
in usr/src/tools/onbld/hgext/cdm.py
370 def cdm_tagchk(ui, repo, active=None, **opts):
371 '''check if .hgtags is active and issue warning
372
373 Tag sharing among repositories is restricted to administrators'''
374
375 if not active:
376 active = wslist[repo].active(opts['parent'])
377
378 ui.write('Checking for new tags:\n')
379
380 if ".hgtags" in active:
381 ui.write('Warning, remove new non-local tags in repository and '
382 'restore .hgtags file.\n'
383 'Adding new tags for sharing among '
384 'repositories is restricted to administrators.\n')
385 return 1
386
387 return 0
It's not obvious to me how to distinguish an administrator
from an ordinary mortal.
Just for laughs, have you tried running usr/src/tools/scripts/flg.flp.sh
using ksh93 rather than /bin/ksh ?
Apart from the above things, the changes look
good to me.
James
--
Senior Kernel Software Engineer, Solaris
Sun Microsystems
http://blogs.sun.com/jmcp http://www.jmcp.homeunix.com/blog
