"James C. McPherson" <James.McPherson at Sun.COM> writes:
> Richard Lowe wrote:
>> Hey all,
>>
>> A webrev is available for prelim code review:
>>
>> http://cr.opensolaris.org/~richlowe/scm-review_90
>>
>> We'd appreciate code review comments from anyone inclined to provide
>> them, but scm-migration folks especially, at the moment.
>>
>> Deadline for comments is Friday May 29th.
>>
>> As the name suggests, this is against onnv_90. The comments in the
>> file list are reconstructed from my notes and bug comments. The file
>> list is http://cr.opensolaris.org/~richlowe/scm-review_90/active.list
>> If you see problems with it, please do point those out too.
>
>
> these should have a 2008 copyright date:
>
> usr/src/tools/onbld/Checks/Cddl.py
> usr/src/tools/onbld/Checks/CStyle.py
> usr/src/tools/onbld/Checks/Comments.py
> usr/src/tools/onbld/Checks/Copyright.py
> usr/src/tools/onbld/Checks/DbLookups.py
> usr/src/tools/onbld/Checks/HdrChk.py
> usr/src/tools/onbld/Checks/Keywords.py
> usr/src/tools/onbld/Checks/Makefile
> usr/src/tools/onbld/Checks/Rti.py
> usr/src/tools/onbld/Checks/__init__.py
> usr/src/tools/onbld/Makefile
> usr/src/tools/onbld/Scm/__init__.py
> usr/src/tools/onbld/__init__.py
> usr/src/tools/onbld/hgext/Makefile
> usr/src/tools/onbld/hgext/__init__.py
> usr/src/tools/scripts/cddlchk.1
> usr/src/tools/scripts/cddlchk.py
> usr/src/tools/scripts/copyrightchk.py
> usr/src/tools/scripts/cstyle.pl
> usr/src/tools/scripts/hdrchk.1
> usr/src/tools/scripts/hdrchk.py
> usr/src/tools/scripts/jstyle.pl
> usr/src/tools/scripts/rtichk.py
> usr/src/tools/scripts/webrev.1
I think someone disagreed with that?
> usr/src/tools/scripts/wx2hg.1 (.TH line)
Except that one :)
> in usr/src/tools/onbld/Scm/Version.py:
> 57 (englishify(GOOD_VERSIONS),
>
Right, I hate that that name, but I wanted to output the list of
acceptable verisons someone presentably.
> in usr/src/tools/onbld/hgext/cdm.py
> 370 def cdm_tagchk(ui, repo, active=None, **opts):
> 371 '''check if .hgtags is active and issue warning
> 372
> 373 Tag sharing among repositories is restricted to administrators'''
> 374
> 375 if not active:
> 376 active = wslist[repo].active(opts['parent'])
> 377
> 378 ui.write('Checking for new tags:\n')
> 379
> 380 if ".hgtags" in active:
> 381 ui.write('Warning, remove new non-local tags in repository and '
> 382 'restore .hgtags file.\n'
> 383 'Adding new tags for sharing among '
> 384 'repositories is restricted to administrators.\n')
> 385 return 1
> 386
> 387 return 0
>
>
> It's not obvious to me how to distinguish an administrator
> from an ordinary mortal.
I believe the assumption is that one would know. Perhaps it should
say "gatekeeper".
> Just for laughs, have you tried running usr/src/tools/scripts/flg.flp.sh
> using ksh93 rather than /bin/ksh ?
We'd briefly discussed this in the last meeting (well, "Discussed" is
the wrong word). My view is that this is not our problem, any truly
supported (well, you know what I mean) build machine has ksh88
present as /bin/ksh. If Indiana is supported as a build machine,
nobody has yet told me. Should I get some free time, I may try it,
but that's the best I'm going to say unless forced to do otherwise.
Thanks!
-- Rich
