I'd like code review for:
514 Check commands should be explicit about their output
515 PYTHON should be /usr/bin/python, not /usr/sfw/bin/python
516 Spelling/grammar nits in hdrchk(1), cddlchk(1), hgsetup(1)
517 onbld Makefiles are too .WAIT happy
520 englishify is an awful function name
523 cddlchk has minor indent problems (space v. tab)
524 Checks.Cddl python nits
525 copyrightchk shouldn't exit immediately on failure
Webrev: http://cr.opensolaris.org/~richlowe/scm_nits
These are all low hanging fruit from the internal code review
comments, with the exception of #514, which is something I noticed
related to one of the comments.
The changes to checks modules have been run through tooltest, the
Makefile changes have been run through several builds/cleans/clobbers
of $SRC/tools (I'm going to start a full build in a moment).
The choice of sys.stderr as the default with #514 is somewhat
arbitrary, the important point (I think), is that the commands are
explicit about where they wish their output to go.
-- Rich
