Richard Lowe writes:
> Webrev: http://cr.opensolaris.org/~richlowe/scm_nits    

Looks mostly good.

On the fix for 517, it seems to me that the 'all' still isn't needed
in usr/src/tools/onbld/Checks/Makefile and
usr/src/tools/onbld/Makefile, but otherwise I'm happy.

> The choice of sys.stderr as the default with #514 is somewhat
> arbitrary, the important point (I think), is that the commands are
> explicit about where they wish their output to go.

That makes sense.

-- 
James Carlson, Solaris Networking              <james.d.carlson at sun.com>
Sun Microsystems / 35 Network Drive        71.232W   Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677

Reply via email to