On Thu, 2008-06-12 at 22:15 -0600, Mark J. Nelson wrote:
> 194-202: It's not clear to me why you're doing wx outchk AND wx out here.
this code was shamelessly stolen from a script I wrote a few years back
which wraps nightly with a few checks (including the 'nothing checked
out'). I do both because:
1) it isn't actually much slower (the first one puts everything into
cache; the second one runs quickly)
2) wx outchk provides the "Doing out check:" messages, etc., and
explains what it's doing.
3) wx out is easier to test for completion.
> It seems like just wx out would be sufficient, as long as you actually
> output the results in the waring message. (Doesn't outchk only warn about
> files that aren't under wx supervision, and so couldn't you get a failure
> with no file output, if it's in the active list but checked out?)
No:
% wx list
usr/closed/cmd/cmd-inet/usr.lib/in.iked/Makefile
usr/closed/cmd/cmd-inet/usr.lib/in.iked/defs.h
usr/closed/cmd/cmd-inet/usr.lib/in.iked/gram.y
usr/closed/cmd/cmd-inet/usr.lib/in.iked/ikelabel.c
usr/closed/cmd/cmd-inet/usr.lib/in.iked/ikerules.h
usr/closed/cmd/cmd-inet/usr.lib/in.iked/initiator.c
usr/closed/cmd/cmd-inet/usr.lib/in.iked/lex.l
% wx edit usr/closed/cmd/cmd-inet/usr.lib/in.iked/lex.l
usr/closed/cmd/cmd-inet/usr.lib/in.iked/lex.l
1.20
new delta 1.21
262 lines
% wx outchk
Doing out check:
Workspace nametable changed: sccs_dirs out of date
Updating /export/ws/sommerfeld/txipsec-perhost/wx/sccs_dirs...this may
take a few minutes.
Warning, the following active list files are checked out:
usr/closed/cmd/cmd-inet/usr.lib/in.iked/lex.l
% wx out
usr/closed/cmd/cmd-inet/usr.lib/in.iked/lex.l
> 301: I think this message should at least refer to $codemgr_parent instead
> of $tw_clone, and even better, be more clear. In your manpage updates,
> you made this clear, and at least before the hg transition, I'm not sure
> that the "tw behind the hg clone" is a valid assumption.
I've changed the message. It now looks like:
----
wx2hg: For file:
usr/closed/cmd/cmd-inet/usr.lib/in.iked/Makefile
the teamware parent:
/export/ws/txipsec/txipsec-gate
doesn't match its mercurial twin; specify the matching revision in
mercurial
with -r hg_rev, or resynchronize them.
Please run
hg --cwd /export/ws/sommerfeld/txipsec-hg-test-3 update -C
before retrying.
----
New webrev is at:
http://cr.opensolaris.org/~sommerfe/onnv-scm.9/index.html
- Bill
