Please review: 538 webrev(1) and hdrchk(1) nits 539 webrev code review nits
Webrev: http://cr.opensolaris.org/~richlowe/scm_wrnits PDF copies of manpages: http://cr.opensolaris.org/~richlowe/scm_wrnits/pdf/ Sample webrev: http://cr.opensolaris.org/~richlowe/scm_wrnits/sample/ The sample webrev is largely useful to get an idea of the orange colour used for the mode warnings ("orange" isn't particularly visible against the background). You'll notice that comments_from_mercurial was removed. This is because we never actually use it, we always get our comments from a wx-format file list, and as such $wxfile is always set, and we always go directly through comments_from_wx, as such I removed it. You'll notice in webrev(1) that a number of .IR references became .BR, This is to match the other manpages we have, and is generally the right thing as best as I understand it. (webrev used to be this way too, I think I must have erroneously changed it). The specific code review comments involved are noted in the two bugs, they are not the full set against each file, but are large subsets thereof. Thanks, -- Rich
