I didn't go back to the feedback page and look for stuff that wasn't included, so this is only a review of the changes that you made.
webrev.sh:1782 - Why fail here if we can't find which_scm? Couldn't we augment the test on 1877-1894 to handle this correctly, and allow success in the case where an active list, workspace path, and parent workspace path were all specified? hdrchk(1): - Under "Additional standards for system header files," bullet item 1 appears to be missing some text describing the form to use when a system file header file is installed in a subdirectory. --Mark On Mon, 23 Jun 2008, Richard Lowe wrote: > Date: Mon, 23 Jun 2008 13:05:23 -0400 > From: Richard Lowe <richlowe at richlowe.net> > To: scm-migration-dev at opensolaris.org > Subject: [scm-migration-dev] Please review #538/#539 > > > Please review: > > 538 webrev(1) and hdrchk(1) nits > 539 webrev code review nits > > Webrev: http://cr.opensolaris.org/~richlowe/scm_wrnits > PDF copies of manpages: http://cr.opensolaris.org/~richlowe/scm_wrnits/pdf/ > Sample webrev: http://cr.opensolaris.org/~richlowe/scm_wrnits/sample/ > > The sample webrev is largely useful to get an idea of the orange > colour used for the mode warnings ("orange" isn't particularly visible > against the background). > > You'll notice that comments_from_mercurial was removed. This is > because we never actually use it, we always get our comments from a > wx-format file list, and as such $wxfile is always set, and we always > go directly through comments_from_wx, as such I removed it. > > You'll notice in webrev(1) that a number of .IR references became .BR, > This is to match the other manpages we have, and is generally the > right thing as best as I understand it. (webrev used to be this way > too, I think I must have erroneously changed it). > > The specific code review comments involved are noted in the two bugs, > they are not the full set against each file, but are large subsets > thereof. > > Thanks, > > -- Rich > _______________________________________________ > scm-migration-dev mailing list > scm-migration-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/scm-migration-dev >
