ok, great. Looks good, once the referenced mistake is cleaned up.
--Mark On Thu, 17 Jul 2008, Richard Lowe wrote: > Date: Thu, 17 Jul 2008 02:38:54 -0400 > From: Richard Lowe <richlowe at richlowe.net> > To: Mark J. Nelson <Mark.J.Nelson at Sun.COM> > Cc: scm-migration-dev at opensolaris.org > Subject: Re: Please review 4758439 > > "Mark J. Nelson" <Mark.J.Nelson at Sun.COM> writes: > >> usr/src/lib/libslp/javalib/com/sun/slp/SLPTemplateRegistry.java >> - Why did you update this copyright? > > A mistake. > >> Should JStyle.py check for @version and warn? > > No, @version (could be) fine, @version based on kewyords is foolish. > >> I assumed that our keywords checks would catch any remaining SCCS >> keywords, if you had missed any. > > Yes. > > -- Rich >
