>                  set -x
>                  hg init $ws/$dir
> -               ( cd $ws/$dir; hg pull -u "$primary_twin"/$dir )
> +               ( cd $ws/$dir; hg pull -u -r $rev "$primary_twin"/$dir )
> +               if (( $? != 0 )); then
> +                       warn "Unable to clone $primary_twin/$dir"
> +                       rev_warning=y
> +               fi
>                  set +x

I think that having the "set -x" active for the exit status check and
warning will be noisy, but I don't think it's critical.

Man, I missed a couple things in my review yesterday (the pull was
missing -r, $hgrev was bogus)... :-(  Glad you caught them.

Anyway, looks good other than that.

mike

Reply via email to